Warnings
GCC
- Strobe, MSYS2 x64 Gtk3, r37189
Making all in c64dtv
c64dtvcpu.c:537:2: warning: #warning "CPUMEMHISTORY implementation for x64dtv is incomplete" [-Wcpp]
537 | #warning "CPUMEMHISTORY implementation for x64dtv is incomplete"
| ^~~~~~~
Making all in c128
c128cpu.c:123:2: warning: #warning "CPUMEMHISTORY implementation for x128 is incomplete" [-Wcpp]
123 | #warning "CPUMEMHISTORY implementation for x128 is incomplete"
| ^~~~~~~
Making all in vic20
Making all in cart
Making all in pet
petcpu.c:69:2: warning: #warning "CPUMEMHISTORY implementation for xpet is incomplete" [-Wcpp]
69 | #warning "CPUMEMHISTORY implementation for xpet is incomplete"
| ^~~~~~~
Making all in plus4
plus4cpu.c:40:2: warning: #warning "CPUMEMHISTORY implementation for xplus4 is incomplete" [-Wcpp]
40 | #warning "CPUMEMHISTORY implementation for xplus4 is incomplete"
| ^~~~~~~
Making all in cbm2
cbm2cpu.c:68:2: warning: #warning "CPUMEMHISTORY implementation for xcbm2 is incomplete" [-Wcpp]
68 | #warning "CPUMEMHISTORY implementation for xcbm2 is incomplete"
| ^~~~~~~
Making all in arch/shared
This is normal behaviour when configuring with --enable-cpuhistory, serves as a reminder to us that CPU history recording hasn't been properly implemented for those machines. (Compyx, 2019-11-19)
- Compyx, MSYS2 x64, Gtk3, r37554M (updated Gtk3 to 3.24.14, GDK to 2.24.3, GLib to 2.64.1)
make[6]: Entering directory '/home/compyx/vice-trunk/win64-build/src/arch/gtk3/novte'
CXX debug.o
CXX iso2022.o
CXX keymap.o
CXX matcher.o
CXX ring.o
CXX table.o
CXX vte.o
CXX vteaccess.o
CXX vteconv.o
CXX vtedraw.o
CXX vtegtk.o
CXX vterowdata.o
CXX vteseq.o
CXX vtestream.o
In file included from C:/msys64/mingw64/lib/glib-2.0/include/glibconfig.h:9,
from C:/msys64/mingw64/include/glib-2.0/glib/gtypes.h:32,
from C:/msys64/mingw64/include/glib-2.0/glib/galloca.h:32,
from C:/msys64/mingw64/include/glib-2.0/glib.h:30,
from ../../../../../vice/src/arch/gtk3/novte/vtegtk.cc:42:
../../../../../vice/src/arch/gtk3/novte/vtegtk.cc: In function 'void vte_terminal_set_color_background(NoVteTerminal*, const GdkRGBA*)':
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:928:4: warning: nonnull argument 'background' compared to NULL [-Wnonnull-compare]
928 | if (expr) \
| ^~
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:934:43: note: in expansion of macro '_G_BOOLEAN_EXPR'
934 | #define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 1))
| ^~~~~~~~~~~~~~~
C:/msys64/mingw64/include/glib-2.0/glib/gmessages.h:624:9: note: in expansion of macro 'G_LIKELY'
624 | if (G_LIKELY (expr)) \
| ^~~~~~~~
../../../../../vice/src/arch/gtk3/novte/vtegtk.cc:2333:5: note: in expansion of macro 'g_return_if_fail'
2333 | g_return_if_fail(background != NULL);
| ^~~~~~~~~~~~~~~~
../../../../../vice/src/arch/gtk3/novte/vtegtk.cc: In function 'void vte_terminal_get_geometry_hints(NoVteTerminal*, GdkGeometry*, int, int)':
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:928:4: warning: nonnull argument 'hints' compared to NULL [-Wnonnull-compare]
928 | if (expr) \
| ^~
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:934:43: note: in expansion of macro '_G_BOOLEAN_EXPR'
934 | #define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 1))
| ^~~~~~~~~~~~~~~
C:/msys64/mingw64/include/glib-2.0/glib/gmessages.h:624:9: note: in expansion of macro 'G_LIKELY'
624 | if (G_LIKELY (expr)) \
| ^~~~~~~~
../../../../../vice/src/arch/gtk3/novte/vtegtk.cc:2901:5: note: in expansion of macro 'g_return_if_fail'
2901 | g_return_if_fail(hints != NULL);
| ^~~~~~~~~~~~~~~~
clang
- gpz (x86, Linux/Gentoo, 64bit, clang 5.0.1, GTK3) (3.2 tarball)
CC=clang CXX=clang LD=clang ./configure --enable-native-tools --enable-arch=native --prefix=/usr/games/ --enable-parsid --with-midas --with-resid --with-xaw3d --with-arts --with-x --enable-native-gtk3ui --enable-ethernet --with-pulse --with-sdlsound --enable-fullscreen --enable-cpuhistory --enable-static-ffmpeg
note: here compiling using clang breaks in either ffmpeg or resid
Making all in gfxoutputdrv
ffmpegdrv.c:126:36: warning: missing field 'next_pts' initializer [-Wmissing-field-initializers]
static OutputStream audio_st = { 0 };
^
ffmpegdrv.c:139:36: warning: missing field 'next_pts' initializer [-Wmissing-field-initializers]
static OutputStream video_st = { 0 };
^
ffmpegdrv.c:512:24: warning: missing field 'pts' initializer [-Wmissing-field-initializers]
AVPacket pkt = { 0 };
^
ffmpegdrv.c:981:28: warning: missing field 'pts' initializer [-Wmissing-field-initializers]
AVPacket pkt = { 0 };
^
Making all in base
keysetdialog.c:98:44: warning: suggest braces around initialization of subobject [-Wmissing-braces]
static GtkWidget *keyset_buttons[3][3] = { NULL };
^~~~
{ }
/usr/lib64/llvm/5/bin/../../../../lib/clang/5.0.1/include/stddef.h:105:16: note: expanded from macro 'NULL'
# define NULL ((void*)0)
^~~~~~~~~~
1 warning generated.
videopalettewidget.c:90:9: warning: unused variable 'index' [-Wunused-variable]
int index = gtk_combo_box_get_active(combo);
^
1 warning generated.
ui.c:427:24: warning: unused variable 'tmp' [-Wunused-variable]
gchar *tmp = g_filename_from_uri(files[i], NULL, NULL);
^
1 warning generated.
uinetplay_new.c:88:9: warning: unused variable 'state' [-Wunused-variable]
int state = gtk_switch_get_active(widget);
^
Making all in ffmpeg
In file included from info.c:34:
./infocontrib.h:293:8: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Andr<E9> Fachat <fachat@physik.tu-chemnitz.de>\n"
^~~~
./infocontrib.h:343:12: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Paul Dub<E9> \n"
^~~~
./infocontrib.h:444:8: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Istv<E1>n F<E1>bi<E1>n\n"
^~~~ ~~~~ ~~~~
./infocontrib.h:532:11: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Frank K<F6>nig <frank_koenig@t-online.de>\n"
^~~~
./infocontrib.h:571:11: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Marko M<E4>kel<E4> <msmakela@gmail.com>\n"
^~~~ ~~~~
./infocontrib.h:622:10: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Lasse <D6><F6>rni <loorni@mail.student.oulu.fi>\n"
^~~~~~~~
./infocontrib.h:655:14: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Pablo Rold<E1>n <pdroldan@yahoo.com>\n"
^~~~
./infocontrib.h:799:19: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
" Peternel, Per H<E5>kan Sundell and David Horrocks for writing\n"
^~~~
./infocontrib.h:841:25: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
{ "1996-2001", "Andr<E9> Fachat", "Andr<E9> Fachat <fachat@physik.tu-chemnitz.de>" },
^~~~
./infocontrib.h:841:41: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
{ "1996-2001", "Andr<E9> Fachat", "Andr<E9> Fachat <fachat@physik.tu-chemnitz.de>" },
^~~~
./infocontrib.h:862:29: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
{ "2004-2017", "Paul Dub<E9>", "French", "Paul Dub<E9> " },
^~~~
./infocontrib.h:862:52: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
{ "2004-2017", "Paul Dub<E9>", "French", "Paul Dub<E9> " },
^~~~
12 warnings generated.
===== This was fixed in r35671 =====
zfile.c:490:17: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
!strcasecmp(tmp + l - len, search) != 0) {
^ ~~
zfile.c:490:17: note: add parentheses after the '!' to evaluate the comparison first
!strcasecmp(tmp + l - len, search) != 0) {
^
( )
zfile.c:490:17: note: add parentheses around left hand side expression to silence this warning
!strcasecmp(tmp + l - len, search) != 0) {
^
( )
1 warning generated.
===== End =====
- cpx (x86_64 Linux/Debian, Gtk3, clang 7.0.1), rev 37193
Making all in cart
ethernetcart.c:153:51: warning: code will never be executed [-Wunreachable-code]
ethernetcart_device.io_source_valid = 0;
^
1 warning generated.
Other diagnostic tools
IWYU - include-what-you-use
IWYU (https://github.com/include-what-you-use/include-what-you-use) is a tool that scans a codebase and reports on #include's that are used, might be missing and may not be needed. It should also report on forward declarations and maybe suggest using those (haven't figured that out yet).
It requires clang/llvm and building the actual tool from source using CMake. The instructions could be better and some stuff doesn't work quite right when following the instructions, but it can built and used (TODO: add instructions on how to properly build and use it (the instructions on copying clang's include/ are wrong and few deps on Debian are missing)).
Currently it has some false positives when using it on Gtk3-VICE: especially when it scans any Gtk3 code, it outputs a lot of extra #include's that aren't required, just #include'ing <gtk/gtk.h> will pull in all of the Glib, GIO, GObject, Atk, Pango, Cairo headers our Gtk3 UI requires.
As an example, here's a run on Gtk3-VICE on Linux which was configured with:
$ ../vice/configure --enable-native-gtk3ui --enable-debug-gtk3ui --enable-debug --enable-ethernet --with-pulse --with-alsa --with-jpeg --with-png --with-gif --enable-x64
The resulting report is 1.7MB of plain text, so I put it on my DropBox: https://www.dropbox.com/s/rr0v8nz3xyx8dn7/iwyu-clang6-vice-r36405.log?dl=0